On Wed, Jul 16, 2008 at 5:49 AM, Johannes Schindelin <[EMAIL PROTECTED]> wrote: >> http://repo.or.cz/w/msysgit.git?a=commitdiff;h=bde036407e1a29a484138290216737589b888093 > > I suspect that you did not want to force negative values in the first > hunk.
The first hunk is called when the option parsing machinery sees a negative number, and treats it as an unknown option. So the minus sign is always present. > A better patch, because it is easier verified, would be to implement > strtoll() in terms of strtoul(), just for this file (where only the sign > matters, but the mantissa is expected to fit into 32 bits). I thought about that, and if there were more than two calls to strtoll, I would certainly have done so. Btw, is it better to simply commit such changes, as I have done, or amend the existing commit and do a 'push +master:mob'? Alexander
