Hi, On Wed, 16 Jul 2008, Alexander Gavrilov wrote:
> On Wed, Jul 16, 2008 at 5:49 AM, Johannes Schindelin > <[EMAIL PROTECTED]> wrote: > > > A better patch, because it is easier verified, would be to implement > > strtoll() in terms of strtoul(), just for this file (where only the > > sign matters, but the mantissa is expected to fit into 32 bits). > > I thought about that, and if there were more than two calls to > strtoll, I would certainly have done so. It would have it made much easier to say "yep, that code is correct". Now it is not that easy. Are you still sure of your preference? > Btw, is it better to simply commit such changes, as I have done, or > amend the existing commit and do a 'push +master:mob'? As long as you try to show your progress, the way you did it is better. Squashing the commits together is easy, splitting them in what you did since you showed us the code last time is not. Thanks, Dscho
