Hi,

On Thu, 10 Apr 2008, Ted Dennison wrote:

> Johannes Schindelin wrote:
> > Most probable.  Could you patch fast-import.c to strip the carriage return?
> > Most likely the proper place would be read_next_command(), maybe these two
> > lines at the end:
> >
> >  if (command_buf.len && command_buf.buf[command_buf.len - 1] == '\r')
> >   strbuf_setlen(&command_buf, command_buf.len - 1);
> >   
> That did the trick.
> 
> I can check that in if you want. However, I'd think for ease of future 
> reintegration you might prefer to bracket it in an "ifdef __MINGW32__" 
> like I've seen in some other sources.

I do not like that ifdef... Rather have something like 
HAS_DOS_LINE_ENDINGS.  IIRC Hannes did something like that in recent 
versions of his big mingw2upstream patch.

Ciao,
Dscho

Reply via email to