On May 2, 2008, at 1:00 PM, Clifford Caoile wrote:
On Fri, May 2, 2008 at 3:19 PM, Steffen Prohaska <[EMAIL PROTECTED]>
wrote:
On May 1, 2008, at 11:18 PM, Peter Harris wrote:
On Thu, May 1, 2008 at 4:03 PM, Scott Graham <[EMAIL PROTECTED]>
wrote:
git.cmd stomps the path. Try changing the line
for /F "delims=" %%I in ("%~dp0..") do set path=%%~fI\bin;%%~fI
\mingw\bin
to
for /F "delims=" %%I in ("%~dp0..") do set
path=%%~fI\bin;%%~fI\mingw\bin;%PATH%
Should git.cmd included in the installer modified in this way?
+1
I don't think there's any problem with adding %PATH% at the end,
unless msysgit depends on fast-fail on non-existant functions.
I don't think so. I pushed a commit to work/cmd. Could you
review it at
http://repo.or.cz/w/msysgit.git?a=commitdiff;h=bf5fd40e3
The current workaround is either the above or to specify the full path
in EDITOR or GIT_EDITOR.
Here's a separate question: Does %%~fl\mingw\bin correspond to a
directory? There doesn't seem to be a mingw\bin anywhere inside of
%PROGRAMFILES%\Git\
In the dev installation (msysgit) this path is valid although
it is not included in the end-user installation. So I think
we should keep it.
Steffen
