Steffen Prohaska:
On Sat, May 3, 2008 at 2:01 AM, Steffen Prohaska <[EMAIL PROTECTED]> wrote:
>
> On May 2, 2008, at 1:00 PM, Clifford Caoile wrote:
>
>> On Fri, May 2, 2008 at 3:19 PM, Steffen Prohaska <[EMAIL PROTECTED]> wrote:
>>>
>>> On May 1, 2008, at 11:18 PM, Peter Harris wrote:
>>>>
>>>> On Thu, May 1, 2008 at 4:03 PM, Scott Graham <[EMAIL PROTECTED]> wrote:
>>>> git.cmd stomps the path. Try changing the line
>>>> for /F "delims=" %%I in ("%~dp0..") do set
>>>> path=%%~fI\bin;%%~fI\mingw\bin
>>>> to
>>>> for /F "delims=" %%I in ("%~dp0..") do set
>>>
>>> path=%%~fI\bin;%%~fI\mingw\bin;%PATH%
>>> Should git.cmd included in the installer modified in this way?
>>
>> +1
>> I don't think there's any problem with adding %PATH% at the end,
>> unless msysgit depends on fast-fail on non-existant functions.
>
> I don't think so. I pushed a commit to work/cmd. Could you
> review it at
>
> http://repo.or.cz/w/msysgit.git?a=commitdiff;h=bf5fd40e3
>
I finally tested this one fix by following the instructions to make an
installer. The fix works with "set GIT_EDITOR=gnuclient" (for Meadow
Emacs) and "set GIT_EDITOR=notepad" (ugh?!), so I think it will work
for "set GIT_EDITOR=gvim" if in the path.
You have my signoff (or is it tested by)?:
Tested-by: Clifford Caoile <[EMAIL PROTECTED]>
I hope it can make the 1.5.6 msysgit release.
Best regards,
Clifford Caoile
