This is a bad commit:

Global symbol "$url" requires explicit package name at 
/opt/local/lib/perl5/site_perl/5.12.4/MTT/Values/Functions/Icc_codecov.pm line 
107.

Please fix.


On Mar 25, 2013, at 12:07 PM, svn-commit-mai...@open-mpi.org wrote:

> Author: miked (Mike Dubman)
> Date: 2013-03-25 12:07:54 EDT (Mon, 25 Mar 2013)
> New Revision: 1607
> URL: https://svn.open-mpi.org/trac/mtt/changeset/1607
> 
> Log:
> Make  mtt doesn't die if connecting failed;
> 
> Text files modified: 
>   trunk/lib/MTT/Reporter/MTTMongodb.pm          |    11 ++++++++++-           
>                   
>   trunk/lib/MTT/Values/Functions/Icc_codecov.pm |    16 +++++++++++++---      
>                   
>   2 files changed, 23 insertions(+), 4 deletions(-)
> 
> Modified: trunk/lib/MTT/Reporter/MTTMongodb.pm
> ==============================================================================
> --- trunk/lib/MTT/Reporter/MTTMongodb.pm      Sat Mar 23 14:57:45 2013        
> (r1606)
> +++ trunk/lib/MTT/Reporter/MTTMongodb.pm      2013-03-25 12:07:54 EDT (Mon, 
> 25 Mar 2013)      (r1607)
> @@ -117,7 +117,16 @@
>       
>       if($enable_mongo == 1)
>       {
> -             eval "\$conn = MongoDB::Connection->new(host => \$url);";
> +             my $flag;
> +             eval "\$conn = MongoDB::Connection->new(host => \$url);
> +                      \$flag=1";
> +             if(defined($flag))
> +             {
> +                     $conn = MongoDB::Connection->new(host => $url);
> +             }else
> +             {
> +                     $conn = undef;
> +             }
>               
>               if(defined($conn))
>               {
> 
> Modified: trunk/lib/MTT/Values/Functions/Icc_codecov.pm
> ==============================================================================
> --- trunk/lib/MTT/Values/Functions/Icc_codecov.pm     Sat Mar 23 14:57:45 
> 2013        (r1606)
> +++ trunk/lib/MTT/Values/Functions/Icc_codecov.pm     2013-03-25 12:07:54 EDT 
> (Mon, 25 Mar 2013)      (r1607)
> @@ -99,9 +99,19 @@
>       if($enable_mongo == 1)
>       {
>               #$conn = MongoDB::Connection->new(host => $dbase_url);
> -             eval "\$conn = MongoDB::Connection->new(host => \$dbase_url);";
> -             $db = $conn->mlnx_mtt;
> -             $codecov_reports = $db->Coverage;
> +             my $flag;
> +             eval "\$conn = MongoDB::Connection->new(host => \$dbase_url);
> +                      \$flag=1";
> +             if(defined($flag))
> +             {
> +                     $conn = MongoDB::Connection->new(host => $url);
> +                     $db = $conn->mlnx_mtt;
> +                     $codecov_reports = $db->Coverage;
> +             }else
> +             {
> +                     $enable_mongo = 0;
> +                     $conn = undef;
> +             }
>       }
>       my $hash_to_insert = {};
>       opendir DIR,"$codecov_dir" or (Warning("Icc codecov: Cannot open 
> codeocdir: $codecov_dir\n") and return 0);
> _______________________________________________
> mtt-svn mailing list
> mtt-...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/mtt-svn


-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to: 
http://www.cisco.com/web/about/doing_business/legal/cri/


Reply via email to