Hi!
On Thursday Jan 23 2014, [email protected] wrote:
> Well, this is embarrassing...
> I forgot to do pretty much about everything. And those that I did were
> wrong.
> The working patch is in the attachment. It is tested and working
Ah, looks interesting. Just a few small things:
- coding style:
- enum values look like MU_COLOR_OPT_NEVER
- lines should go over 80 char
- the type of a function is on a separate line
- error handling:
- config_options_set_color should issue an error (in the Gerror)
when there's an invalid value
- the nocolor variable should probably be remove
- the man-page needs an update as well.
Thanks,
Dirk.
--
Dirk-Jan C. Binnema Helsinki, Finland
e:[email protected] w:www.djcbsoftware.nl
pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D DA3C
--
You received this message because you are subscribed to the Google Groups
"mu-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
