I am updating the manual as below. Also, I am very hesitant towards
removing all --nocolor options from the code.
It is far too big of a diff for such a small feature. I want to use the
"--color" option but the "nocolor" boolean variable. Is that OK?
I've also noticed that this revives the "--color" flag (opposite of
--nocolor) from previous versions ("** Release 0.9.6 <2011-05-28 Sat>" from
"https://github.com/djcb/mu/blob/master/NEWS";)
COLORS
Some mu sub-commands support colorized output using the --color
option. This option mimics the
behaviour of same option in the GNU-version of ls-command : With
"--color=auto", output is col‐
orized only when stardard output is connected to a terminal.
--color=never doesn't print col‐
orized output in any case, and --color=always will always print
colors.
The default value is --color=always.
Currently, mu find, mu view, mu cfind and mu extract support colors
On Sat, Jan 25, 2014 at 10:25 AM, <[email protected]> wrote:
> nocolor option is removed though. It still checks for the nocolor env.
> variable, if that's what you mean. And the nocolor variable is kept in
> mu_config because it's simpler to check against a boolean when printing a
> value than an enum.
>
> I was under the impression that returning false from
> config_options_set_color would cause an error (not that I've tried).
> Anyway, I'll make the changes and update my pull request
>
> On Sat, Jan 25, 2014 at 02:17:20AM +0200, Dirk-Jan C. Binnema wrote:
> > Hi!
> >
> > On Thursday Jan 23 2014, [email protected] wrote:
> >
> > > Well, this is embarrassing...
> > > I forgot to do pretty much about everything. And those that I did were
> > > wrong.
> > > The working patch is in the attachment. It is tested and working
> >
> > Ah, looks interesting. Just a few small things:
> >
> > - coding style:
> > - enum values look like MU_COLOR_OPT_NEVER
> > - lines should go over 80 char
> > - the type of a function is on a separate line
> >
> > - error handling:
> > - config_options_set_color should issue an error (in the Gerror)
> > when there's an invalid value
> >
> > - the nocolor variable should probably be remove
> >
> > - the man-page needs an update as well.
> >
> > Thanks,
> > Dirk.
> >
> >
> > --
> > Dirk-Jan C. Binnema Helsinki, Finland
> > e:[email protected] w:www.djcbsoftware.nl
> > pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D DA3C
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "mu-discuss" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to [email protected].
> > For more options, visit https://groups.google.com/groups/opt_out.
>
--
You received this message because you are subscribed to the Google Groups
"mu-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
