On 4/13/05, Karsten Ohme <[EMAIL PROTECTED]> wrote:
> Hello,

Hi,

Very nice work. I also have some remarks :-):

> I have changed the include
> 
> -#include <winscard.h>
> +#include "pcsclite.h"

Why do you use " " instead of < >?
pcsc-lite should already be installed so the pcsclite.h file should be
found using < >.

> Under Unix this file is generated from pcsclite.h.in, but the make
> process is not usable under Windows.

And how do you propose to solve this?
You have to manually generate the pcsclite.h file from pcsclite.h.in?


> I have removed some debug code. There were only five places with debug
> code and no continuous and exhausting use of it.

I don't know if that is a good idea. It does not hurt so I will keep
them unless you strongly disagree.

> A file install.w32 is included instructing the build process.

The file is not included in the patch. Use --new-file (or -N) with
diff to include new files.

Bye,

-- 
 Dr. Ludovic Rousseau
 For private mail use [EMAIL PROTECTED] and not "big brother" Google

_______________________________________________
Muscle mailing list
[email protected]
http://lists.drizzle.com/mailman/listinfo/muscle

Reply via email to