Hello,

On 4/13/05, Karsten Ohme <[EMAIL PROTECTED]> wrote:

Hello,


Hi,

Very nice work. I also have some remarks :-):

Thanks, this version today has also the new function MSCDeleteKey(). On the Internet location are also zips with the adjusted CardEdge, MCardPlugin and muscleTools. No diffs for this at the moment. But the function changes the structure where all functions are contained. Maybe all other libraries (e.g. PKCS#11) has to be compiled new.


At me this new functions works with my Giesecke & Devrient [EMAIL PROTECTED] Expert 64. A Cyberflex e-gate32k has problems with this. Maybe this company has again saved some money and saved some functionality.

The keypad functions in MCardplugin does only work for my Kobil reader. Maybe there has to be a configuration file for this to also enable other readers. Have no perfect solutions for this at the moment, I believe there is no standard. But some software recognizes different readers with this capabilities. So there must be a way.



I have changed the include

-#include <winscard.h>
+#include "pcsclite.h"


Why do you use " " instead of < >?
pcsc-lite should already be installed so the pcsclite.h file should be
found using < >.

If it is, Okay. But at me it is in the local directory. And Windows does not have the file pcsclite.h.




Under Unix this file is generated from pcsclite.h.in, but the make
process is not usable under Windows.


And how do you propose to solve this?
You have to manually generate the pcsclite.h file from pcsclite.h.in?

Well there would maybe ways with cygwin. But is would be a horrible way. A ready build version should be shipped with libmusclecard.





I have removed some debug code. There were only five places with debug
code and no continuous and exhausting use of it.


I don't know if that is a good idea. It does not hurt so I will keep
them unless you strongly disagree.

No, don't mind. I only cleaned up to see something more.



A file install.w32 is included instructing the build process.


The file is not included in the patch. Use --new-file (or -N) with
diff to include new files.

http://www.inf.tu-dresden.de/~ko189283/MuscleCard/

Bye, Karsten
_______________________________________________
Muscle mailing list
[email protected]
http://lists.drizzle.com/mailman/listinfo/muscle

Reply via email to