On 4/21/05, Karsten Ohme <[EMAIL PROTECTED]> wrote:
Ludovic Rousseau wrote:
Can you send me the patch?
http://www.inf.tu-dresden.de/~ko189283/MuscleCard/
Can you please use diff -u and regenerate the patch?
Where does the file libmusclecard/src/PCSC/capabilities.h comes from? You wrote it yourself?
Yes. My CardEdge supports the retrieval of all capabilities from the card. Some more definitions for all the Cipher and Signature algorithms are also necessary. There are included in the file cryptalg.h. I have used a separate file with all defines with the prefix NMSC for N - "new". You can also integrate everything in musclecard.h.
I have ignored all MSCKeyPolicy and not defined the new cipher mode restrictions, because it is not supported by the applet and I also see no use to restrict the keys to any algorithm.
The Applet at the location can e.g. sign a arbitrary text in multiple blocks. It is working on a Giesecke & Devrient Card [EMAIL PROTECTED] Expert 64, at the moment not on a Cyberflex e-gate 32k.
You copied verbatim a lot of header and source files from pcsc-lite.
For pcsclite.h this is not true, because it is autogenerated and so not available for Windows. I also changed
#ifdef WIN32
#include <winscard.h> #define snprintf _snprintf #ifndef SCARD_E_UNSUPPORTED_FEATURE #define SCARD_E_UNSUPPORTED_FEATURE 0x80100022 #endif
#else #include "unix/winscard.h" ...
The feature SCARD_E_UNSUPPORTED_FEATURE is not available under Visual Studio 6.0.
And winscard.h is already there in Windows. It can not be included from the file winscard.h like in Unix. So every header file must include pcsclite.h and pcsclite.h decided which version of winscard.h it should include.
musclecard.h is also not the same, because it includes e.g.
A new error code:
/*
* New PINs are not identical (happens if PIN is changed with keypad)
*/
#define MSC_PINS_NOT_IDENTICAL 0x9C61and also the new capabilities (capabilities.h).
In file mscdefines.h
e.g. the new function
MSCPVoid32 pvfDeleteKey;
is defined in the function structure.
Some more functions will come (e.g. to delete a pin)
It is not the correct way to go. Can't you use the ones from pcsc-lite event if pcsc-lite is not installed (just the source code)?
Okay. These files can also be moved to the pcsc-lite sources. But for a Windows system these files must be offered in a separate packet and it must be mentioned where to get it, best at the same location.
Thanks,
Bye, Karsten
_______________________________________________ Muscle mailing list [email protected] http://lists.drizzle.com/mailman/listinfo/muscle
