Re: Segmentation fault from mutt-1.5.17 with SMTP

[Kyle Wheeler]

On Monday, November 10 at 11:42 PM, quoth TAKAHASHI Tamotsu:

This has already been fixed:

1970-01-01 00:00 +0000  Brendan Cully  <[EMAIL PROTECTED]> (a2e8f6fab8d3)

       * smtp.c: Test that envelope from or from is set before attempting
       SMTP delivery. Closes #3079.

Oh wait, since over 38 years ago?

Oh, wait, nevermind. The fix is in there, I just didn't see it the first time.

But I just noticed, shouldn't smtp.c have this patch:

--- smtp.old    2008-11-10 08:58:39.000000000 -0600
+++ smtp.c      2008-11-10 08:59:20.000000000 -0600
@@ -242,8 +242,7 @@ mutt_smtp_send (const ADDRESS* from, con
     FREE (&AuthMechs);

-    ret = snprintf (buf, sizeof (buf), "MAIL FROM:<%s>",
-                    EnvFrom ? EnvFrom->mailbox : from->mailbox);
+    ret = snprintf (buf, sizeof (buf), "MAIL FROM:<%s>", envfrom);
     if (eightbit && mutt_bit_isset (Capabilities, EIGHTBITMIME))
     {
       safe_strncat (buf, sizeof (buf), " BODY=8BITMIME", 15);

It goes to all the trouble of setting envfrom, but then never uses it.

~Kyle
--

                                                    -- Henry Kissinger

/* send the sender's address */ University politics are vicious precisely because the stakes are so small.

pgpGv6gWXCEWx.pgp
Description: PGP signature