David Champion wrote:
> Obviously we can't delete from encrypted messages, but the current
> code actually prevents deletion from signed messages as well (and
> gives an erroneous message).  David's patch:
> 
> --- orig.recvattach.c Tue Nov 28 16:27:34 2006
> +++ recvattach.c      Tue Nov 28 16:56:00 2006
> @@ -1087,7 +1087,7 @@
>       }
>  #endif
>  
> -        if (WithCrypto && hdr->security & ~PGP_TRADITIONAL_CHECKED)
> +        if (WithCrypto && (hdr->security & ENCRYPT))
>          {
>         mutt_message _(
>           "Deletion of attachments from encrypted messages is unsupported.");
> 
> I do like that we resist deleting attachments that are part of signed
> content.  But maybe we should allow deleting the signature itself, so
> that there's a two-step process for deleting any attachment?  Just a
> passing thought, put out for discussion if anyone is interested.

I think once this patch is applied, mutt will no longer block the
deletion of the signature too (for an unencrypted email), right?

We could have the code allow it both ways: if they try to delete an
attachment (except for the signature), we ask confirmation with a
warning that it will invalidate the signature.  If they try to delete
the signature, then we make sure to flip the SIGN bit off.  Would that
work?

-Kevin

Attachment: signature.asc
Description: PGP signature

Reply via email to