Re: [PATCH] Adds the '@' pattern modifier to limit matches to known aliases

[Kevin J. McCarthy]

On Tue, Aug 30, 2016 at 04:35:20PM -0700, d...@bikeshed.us wrote:
> Adds the '@' pattern modifier to limit matches to known aliases.
> 
> Example: ~f joe matches messages from joe. @~f joe matches messages from
> any joe who is defined as an alias.

Looks fine to me.  I just have two extremely minor nits below.

> diff --git a/pattern.c b/pattern.c
> --- a/pattern.c
> +++ b/pattern.c
> @@ -1010,8 +1022,10 @@
>    {
>      for (a = va_arg (ap, ADDRESS *) ; a ; a = a->next)
>      {
> -      if (pat->alladdr ^ ((a->mailbox && patmatch (pat, a->mailbox) == 0) ||
> -        (match_personal && a->personal && patmatch (pat, a->personal) == 0)))
> +      if (pat->alladdr ^
> +          ((!pat->isalias || alias_reverse_lookup(a)) &&

                                alias_reverse_lookup (a)

> +           ((a->mailbox && patmatch (pat, a->mailbox) == 0) ||

                              !patmatch (pat, a->mailbox))
(since you changed it below, just for symmetry)

> +         (match_personal && a->personal && !patmatch (pat, a->personal) ))))

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

signature.asc
Description: PGP signature