#3862: Error in POP3 authentication via SASL mechanism DIGEST-MD5
-----------------------+----------------------
Reporter: g1pimutt | Owner: mutt-dev
Type: defect | Status: new
Priority: major | Milestone:
Component: POP | Version:
Resolution: | Keywords:
-----------------------+----------------------
Comment (by kevin8t8):
Okay I've been trying to dive into it a little deeper, and have been
looking more closely at your patch. I understand your warning: the code
is more complicated than it first seems. :-)
I unrolled the loop a bit, to make it more like the imap code, and tried
making other changes to avoid peeking at inbuf. But in the end, you have
to peek at inbuf to know whether to go through another socket_write and
socket_read or exit the loop when you receive SASL_OK.
I think the only thing that makes me nervous is that it (theoretically)
could exit prematurely now. Would it make more sense to do:
{{{
if (rc != SASL_CONTINUE &&
(rc != SASL_OK || !mutt_strncmp(inbuf, "+OK", 3)))
break;
}}}
Thanks for your patience with me: I wasn't very familiar with this code,
and I don't like committing patches I don't understand.
--
Ticket URL: <https://dev.mutt.org/trac/ticket/3862#comment:9>
Mutt <http://www.mutt.org/>
The Mutt mail user agent
