#3899: mutt_ssl's interactive_check_cert() has several issues -----------------------+---------------------- Reporter: kevin8t8 | Owner: mutt-dev Type: defect | Status: closed Priority: major | Milestone: Component: crypto | Version: Resolution: fixed | Keywords: -----------------------+----------------------
Comment (by vinc17): Replying to [comment:10 derekmartin]: > Replying to [comment:2 vinc17]: > > {{{ > > #define numberof(x) (sizeof (x) / sizeof ((x)[0])) > > > > for (i = 0; i < numberof(parts); i++) > > }}} > > I think this kind of macro, much like the macro in bug #3880, is bad business. What if it gets used with a pointer rather than an array? The syntax is still fine, it'll compile, but it will break, in a way that may be difficult to notice, depending on exactly how it's used. The macro can be modified to check whether the variable is a pointer. So, I don't see any problem. -- Ticket URL: <https://dev.mutt.org/trac/ticket/3899#comment:16> Mutt <http://www.mutt.org/> The Mutt mail user agent