On Fri, Dec 12, 2025 at 10:07:36AM +0800, Kevin J. McCarthy wrote:
> On Thu, Dec 11, 2025 at 03:24:08PM +0000, Yao Zi via Mutt-dev wrote:
> > This patch adds extra error log about the recipient address when an RCPT
> > TO command fails. Users then could easily distinguish the problematic
> > recipient, and remove it or contact the provider for support.
>
> The patch looks okay, but I think it would be better to put the mutt_sleep()
> after the mutt_error(), rather than before, so the user has a chance to read
> the error message.
I added the sleep before mutt_error() since smtp_get_resp() itself may
show the raw server response in case of error, which may be helpful for
the user in the case, for example,
SMTP session failed: 550 5.4.6 An email sent to this address has
been rejected with the reason 'Mailbox does not exist' within the
last 30 days.
with my mail provider.
However, I don't see other places that may print errors after the call
to mutt_error() added in this patch. In my testing, the "cannot add
recipient" error message is the last one shown in the status bar after
sending the message (and failing). It remains here until I press some
keys, so I don't think it's necessary to add a sleep after the
mutt_error().
Did I miss something? Or in some cases there will be some errors printed
after the new call to mutt_error()?
> If you are okay with me making that simple change I'll commit it to master,
> or you can resubmit the patch.
If a sleep after mutt_error() is indeed necessary, I would prefer to add
another sleep after mutt_error() with the sleep before it kept. I'll be
grateful if you could change and commit it for me!
>
> Thanks!
>
> --
> Kevin J. McCarthy
> GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
Best regards,
Yao Zi
