On Fri, Dec 12, 2025 at 03:41:03AM +0000, Yao Zi via Mutt-dev wrote:
On Fri, Dec 12, 2025 at 10:07:36AM +0800, Kevin J. McCarthy wrote:The patch looks okay, but I think it would be better to put the mutt_sleep() after the mutt_error(), rather than before, so the user has a chance to read the error message.I added the sleep before mutt_error() since smtp_get_resp() itself may show the raw server response in case of error, which may be helpful for the user in the case, for example, SMTP session failed: 550 5.4.6 An email sent to this address has been rejected with the reason 'Mailbox does not exist' within the last 30 days. with my mail provider.
Oh, I see. Sorry, my mistake.
However, I don't see other places that may print errors after the call to mutt_error() added in this patch. In my testing, the "cannot add recipient" error message is the last one shown in the status bar after sending the message (and failing). It remains here until I press some keys, so I don't think it's necessary to add a sleep after the mutt_error().
Other places in the code base usually put a sleep() after a mutt_error() when it might be overwritten, but now I understand what you are doing.
This looks fine as-is then. I'll commit it shortly. Thank you for the patch! -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
