On Thu, Jan 08, 2026 at 09:33:06PM +0800, Kevin J. McCarthy wrote:
> On Thu, Jan 08, 2026 at 10:15:09AM +0000, Yao Zi via Mutt-dev wrote:
> >Let's stop bailing out early when failing to decode SASL challenge as
> >base64. Instead, print a debug message and then try to continue the
> >authentication process for better compatibility with these quirky
> >service providers.
> 
> Thank you for the patch.  Funnily enough, we just fixed the same problem
> in the SMTP code, for GSASL only (the Cyrus SASL code was working okay
> for some reason).
> 
> In that fix, I preferred to ignore base64 decoding problems for only the
> first response from the server, just to limit the scope of the
> workaround for the server bug.  (See
> https://gitlab.com/muttmua/mutt/-/commit/b363b602e17906f63f3177f9899cd6c150e746ab)
> 
> Would you mind changing your patch to behave the same?

Sure I wouldn't. Will send a new version later, and thanks for the review.

Regards,
Yao Zi

> --
> Kevin J. McCarthy
> GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

Reply via email to