On Sun, Jan 25, 2026 at 06:30:22PM +0800, Kevin J. McCarthy wrote:
> @@ -305,6 +306,12 @@ int mbox_parse_mailbox (CONTEXT *ctx)
> {
> #define PREV ctx->hdrs[ctx->msgcount-1]
>
> + if (!has_mbox_sep)
> + {
> + dprint (1, (debugfile, "mbox_parse_mailbox: missing separator at
> location: "
> + OFF_T_FMT "\n", loc));
> + }
> +
> if (PREV->content->length < 0)
> {
> PREV->content->length = loc - PREV->content->offset - 1;
Nit, no tabs for the new lines added, but there is for the existing ones
in this function.
> @@ -392,9 +400,11 @@ int mbox_parse_mailbox (CONTEXT *ctx)
> }
> }
>
> - /* return to the offset of the next message separator */
> - if (fseeko (ctx->fp, tmploc, SEEK_SET) != 0)
> + /* return to the offset of the next *mbox* separator */
> + if (fseeko (ctx->fp, tmploc - 1, SEEK_SET) != 0)
> dprint (1, (debugfile, "mbox_parse_mailbox: fseek() failed\n"));
> +
> + expect_from_line = 1;
Nit, you are not using a tab here for indentation, but there was one on
the line above this. I don't know if it really matters, but it stood
out to me on the diff.
If none of this matters, please just ignore these review comments :)
thanks,
greg k-h
