On Sun, Jan 25, 2026 at 07:52:20PM +0800, Kevin J. McCarthy wrote: > On Sun, Jan 25, 2026 at 11:55:49AM +0100, Greg KH wrote: > > Nit, you are not using a tab here for indentation, but there was one on > > the line above this. I don't know if it really matters, but it stood > > out to me on the diff. > > > > If none of this matters, please just ignore these review comments :) > > Thanks Greg! > > It hasn't historically mattered (to me), but now that it's a wider team I'll > defer to how the team feels. > > The code base is mixed, with some places having tabs and some not. I > personally have my editor set to "no tabs", but can certainly adjust that. > > Feedback, everyone?
In all of the research on coding style that has happened, in the end, the only thing that matters is "be consistent". You can argue about tabs/spaces, indentation levels, location of braces and everything else, but that doesn't really matter. Just pick one set of things and stick with that for the whole codebase. Our brains are great, we see patterns easily, and deviations from those patterns "hurt" our brains, so consistancy matters (hence why these tiny deviations jumped out at me.) So as it's your project, you get to choose, pick what you want for the specifics and declare it and we will all go along with it :) thanks, greg k-h
