On Sun, Mar 22, 2026 at 05:45:10PM +0800, Kevin J. McCarthy wrote: > Hi Everyone, > > As I mentioned I would this weekend, I've pushed the reformatted code to a > branch, kevin/clang-format, on gitlab. > > I don't expect anyone to take a look at the gigantic diff, but if you have > time to browse through a few of the source code files, I'd appreciate your > opinions. > > As I mentioned previously, I've turned off space-before-function. I also > made a few small tweeks to the clang-format config as I tried it out. > > The output is pretty much what I mentioned earlier. There are some places > where the formatting isn't great. But (IMO) overall it smoothed things over > for the variations in the code. I'll let you judge though. > > Thank you, > > -- > Kevin J. McCarthy > GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
This #v+ -#ifndef RE_NREGS -#define RE_NREGS 30 -#endif - +# ifndef RE_NREGS +# define RE_NREGS 30 +# endif #v- made me stumble. At first I thought 'Right, space after shell comments' only to realize that this is cpp not shell... :-) I reverted the above and also did a 's/\([A-z]\)(/\1 (/g' to make the diff less noisy before reviewing. While I see some value in the remaining changes (and in general agree about the parentheses style) I'm still not convinced this is worth the noise. It also adds some horrible things like: #v+ - (!ciss->path || url_pct_decode (ciss->path) >= 0) ? 0 : -1; + (!ciss->path || url_pct_decode (ciss->path) >= 0) ? + 0 : + -1; #v- and #v+ - scratch[taglen] = 0; /* overwrite the colon as mutt_parse_rfc822_line expects */ + scratch[taglen] = + 0; /* overwrite the colon as mutt_parse_rfc822_line expects */ #v- Just my 2c.
