On Sun, Mar 22, 2026 at 05:45:10PM +0800, Kevin J. McCarthy wrote:
The output is pretty much what I mentioned earlier. There are some places where the formatting isn't great. But (IMO) overall it smoothed things over for the variations in the code. I'll let you judge though.
I've let this sit all week, so hopefully that's long enough to give everyone a chance to chime in.
I've decided for now to drop the clang-format cleanup. If its output was better quality, it would have been nice to have. But it behaves weirdly, and if we leave the .clang-format config in there, I'm afraid we'll be encouraging source files to be automatically reformatted by potential patch submitters.
However, I've spent this evening scripting two formatting changes I would like to make manually. One is fixing 'int* foo' to 'int *foo' in those places in the code that do that. Two is removing the space before parens in funcalls.
I need tomorrow, and perhaps Sunday to go through the results and clean some places up, but I expect to send patches Sunday or Monday. It's not as awesome as a full format tidy, but I think those two things will have a nice overall effect on the code.
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
