On Fri, May 01, 2026 at 12:19:34PM +0200, Oswald Buddenhagen via Mutt-dev wrote:
the subject and (lack of) description left me guessing what this patch even is about, so you may want to expand it.also, to be super-pedantic, you are adding "i18n of percentages". l10n is the process of populating the .po files with actual translations.this affects the naming in the code as well.
The L10N flags on the comments end up as comments to the translators.
On Fri, May 01, 2026 at 12:47:11PM +0800, Kevin J. McCarthy wrote:it's kind of funny to see that in a patch that improves i18n, because such word puzzles are about as i18n-hostile as it gets. of course it doesn't actually matter here, because that format string isn't i18n'd - but maybe it should be? conventions on ordering and parenthesizing things vary between locales.+++ b/curs_lib.c - mutt_message("%s %s/%s (%d%%)", progress->msg, posstr, progress->sizestr, + mutt_buffer_addstr(messagefmt, "/%s ("); + mutt_buffer_addstr(messagefmt, mutt_l10n_percentage()); + mutt_buffer_addstr(messagefmt, ")");
This was suggested by a translator, I merely cleaned it up. So apparently it's useful to at least one of the Mutt translators.
I don't think doing it for the whole format string would help. Maybe you were being funny too, though?
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
