Follow-up Comment #2, bug #20279 (project mypaint): Okay, hopefully fixed in a way that's right for all use cases:
https://gitorious.org/mypaint/mypaint/commit/a22e286b279e Behaviour of "x" history during a stroke: * In a continuous movement with the pen held down, pressing "x" toggles between the colours which are found at hist[-1] and hist[-2] at the start of the movement. * If the pen is held in one position while strokes are being laid down, and "x" is pressed repeatedly, the entire history is cycled through. This is the desired 0.9 behaviour, I think. Behaviour of the Colour subwindow's display of the most-recently painted colour: * When a stroke is split for any reason (e.g. after the end of an input stroke plus a small amount of time and a motion-notify event, or during a long stroke's motion-notify events), the brush colour at the split point is pushed onto the end of the history. * The user pressing "x" in the middle of a long stroke is a special case of the above: it splits the model stroke, starting one with a new colour. * When the user finishes a drawing action with pressure, the brush colour is pushed onto the end of the history. It doesn't matter if this happens outside the window because we receive the button-release event anyway due to the implicit grab. This is two callbacks related to the end of a drawing action with pressure, not one, but neither is redundant. The first is required for correctness with zero-pressure splatter brushes and within strokes; the latter is required for UI responsiveness. We perform de-duplication on the history, so it should be fine. _______________________________________________________ Reply to this item at: <http://gna.org/bugs/?20279> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Mypaint-bugs mailing list [email protected] https://mail.gna.org/listinfo/mypaint-bugs
