> This should address most of the concerns I have seen. On the other hand no > point in us coding it if Isaac remains uninterested in having the function. > Mainly I suggested it because with the current autoexpire it was very easy > to code, literally just a few lines in a few places. It's getting more > complex. :-)
You were the first person (that I recall) to even notice that I treated the autoexpire field as a integer rather than a boolean. This is one of a few features that were put in the original AutoExpire implementation that were put in to allow easy expansion of the AutoExpire functionality. In the query in AutoExpire::FillOldestFirst(), I check that autoexpire > 0 and then ordered by autoexpire so that it could potentially be used for a similar purpose to what you're describing. I added a AutoExpireMethod setting even though there is only one option "Oldest Show First". The code was setup to allow easy addition of other methods just by adding a couple lines to the case statement in AutoExpire::FillExpireList() and adding the corresponding "Fill" method for the AutoExpireMethod. I was thinking that people might add other methods like "Only expire things in the AutoExpire Recording Group", or "Expire by reverse recording priority", etc.. These are trivial to implement, but like a lot of the features I've added, I hardly use AutoExpire. :) I have auto-expire set on a bunch of my lower priority shows that I watch if there's nothing better recorded, but I don't set it for the shows I regularly watch. I manually delete everything, and AutoExpire rarely has to delete anything unless I'm out of town for a few weeks. The undelete functionality you describe could be implemented easily enough by just moving recordings into a "AutoExpire" Recording Group and implementing the AutoExpire code to only expire programs in that group. "Undeleting" a program would just require moving the program back into another Recording Group. This would require no new interface changes, wouldn't give a false perception of how much free space there is, etc.. If we wanted to get fancy, there could possibly be another setting to make the Delete popup aware of the "AutoExpire" Recording Group. If the user had their AutoExpire method set to "Expire from AutoExpire Recording Group", then the Delete popup could give the user another option in addition to the existing options. The new option would just move the recording into the AutoExpire Recording Group instead of telling the backend to delete the recording. -- Chris
_______________________________________________ mythtv-dev mailing list [email protected] http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
