On Saturday 07 January 2006 21:56, David Abrahams wrote:
> Okay, I got it working, as far as I can tell; the patch against this
> morning's source (Version 8516) is enclosed.

Comments:

- The amount of ifdefs you've added are not good.  Create new classes when the 
code is significantly different, as it is in this case.
- I assume that this should be compile-time optional, and it's not?
- I'd prefer not to have more device-specific code in tv_rec than there 
already is.

Isaac
_______________________________________________
mythtv-dev mailing list
[email protected]
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Reply via email to