Jim Westfall <[EMAIL PROTECTED]> writes: > Daniel Kristjansson <[EMAIL PROTECTED]> wrote [01.09.06]: >> On Mon, 2006-01-09 at 08:50 -0500, David Abrahams wrote: >> > As I do my refactoring, it begins to look to me as though the original >> > FirewireChannel code has a few problems. Close() doesn't seem to do >> > anything, for example. Also, if the channel failed to open, >> > SetChannelByString generates an error message about having the wrong >> > kind of device and then returns true. >> >> The FirewireRecorder code is not our finest example of a recorder, >> it was written by one guy who then disappeared. It was actually >> impressive how quickly he got it together, but it needed on-going >> care to iron out the oddities... >> > > I am still here. I havent touched it cause I wasnt aware anything was > wrong. If there is let me know and I will fix/test it.
I have just factored a great deal of common code used by the OSX stuff out of firewirerecorder/firewirechannel, and it would be really superb if you could review and test my changes. -- Dave Abrahams Boost Consulting www.boost-consulting.com _______________________________________________ mythtv-dev mailing list [email protected] http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
