Bugs item #3451286, was opened at 2011-12-05 04:10
Message generated for change (Tracker Item Submitted) made by cpudney
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=744692&aid=3451286&group_id=139835
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Chris Pudney (cpudney)
Assigned to: Nobody/Anonymous (nobody)
Summary: IsotopePatternScoreCalculator.checkMatch is redundant
Initial Comment:
I was working on PeakListIdentificationTask when I noticed that there is some
redundant code in retrieveIdentification():
for (String compoundID : compoundIDs) {
...
boolean check = IsotopePatternScoreCalculator.checkMatch( rowIsotopePattern,
compoundIsotopePattern, isotopeFilterParameters);
if (!check) continue;
}
Surely, the continue at the end of a loop has no effect?
I've committed the change I was working on (repaint when a new identity is
added) and deleted the redundant if(!check).
Should the result of checkMatch be used in some way?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=744692&aid=3451286&group_id=139835
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Mzmine-devel mailing list
Mzmine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mzmine-devel
