Hi all
The Gap.java file is used both for the targetedpeakdetection and the peakfinder
module. Why are they not sharing the same file?
I identified a problem with Gap.java which causes the last data points to be
excluded in some chromatograms:
[cid:image001.png@01D0656B.FB65C040]
Part of the problem was the implementation of the subList function. The toIndex
is exclusive not inclusive. I solved this by changing the line to:
bestPeakDataPoints = currentPeakDataPoints.subList(startInd,
Math.min(currentPeakDataPoints.size(), stopInd+1));
Now one more data point is included, however the zero value data point is still
missing for the peak:
[cid:image002.png@01D0656C.9D6FAF40]
The reason is that no zero value data point is added at the end of a peak to
currentPeakDataPoints for some of the peaks. I have no idea why and was hoping
that someone with more knowledge about the algorithm could have a look at what
is causing this. I expect that this bug also exist in the gap filling module
and therefore I think it is of high priority to fix this.
Happy Easter everyone - I hope you have a nice time with your family and loved
ones!
Best,
Thomas
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Mzmine-devel mailing list
Mzmine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mzmine-devel
