Hi Kevin, > I traced it to PropertyDictionary.cs not checking to see if a property was > already present before adding it. > > Here is my fix sorry about the lack of diff. Basically added a check to not > allow duplicates to the PropertyDictionary.
The fix seems to already have been commited by someone else. However, may I argue _against_ this fix? There are two reasons I don't like it: a- It changes semantics. PropertyDictionary inherits from DictionatyBase. Common semantics in all of .NET standard dictionary collections dictate that you can't add the same item twice. This change breaks that. b- Common sence would dictate that the results from the sysinfo task should be added as readonly properties. Currently, they are not, since it uses PropertyDictionary::Add(), not AddReadOnly(). My proposal for a fix would actually be to leave PropertyDictionary alone, and instead modify SysInfo so that it uses indexer access to add it's properties. That simple change would satisfy both elements I outline above. What does anybody else think? -- Tomas Restrepo [EMAIL PROTECTED] ------------------------------------------------------- This sf.net email is sponsored by: Access Your PC Securely with GoToMyPC. Try Free Now https://www.gotomypc.com/s/OSND/DD _______________________________________________ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
