Hi Ian,

> So I'm happy to go with Tomas's solution - leaving the sys properties
> non read only.

OK, I'm game. I've done the fix and added a couple of new unit tests to the
SysInfo task to ensure both conditions hold true :)

While looking through the code, though, I noticed that the code in
PropertyDictionary's indexer is:

set {
  if (!_readOnlyProperties.Contains(name)) {
    Dictionary[name] = value;
  }
}

Now, this will silently be ignored if the property is readonly. Somehow, I
don't think this is good behavior; it's confusing at best. Even more
cumbersome is the fact that some of the code is relying on this wicked
behavior. For example, unit tests for NAnt.Console actually _check_ for this
silent change attempts to be ignored.

Any comments?

--
Tomas Restrepo
[EMAIL PROTECTED]



-------------------------------------------------------
This sf.net email is sponsored by:
Access Your PC Securely with GoToMyPC. Try Free Now
https://www.gotomypc.com/s/OSND/DD
_______________________________________________
Nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers

Reply via email to