> 3. Maybe we should start by implementing it the simple way: Make
"includes"
> and "excludes" support filesets (both referenced and nested):
>
> <fileset basedir="dir.a">
>         <includes file="aaa.txt" />
>         <includes fileset="r1" />
>         <includes>
>                 <fileset basedir="dir.b">
>                         <includes file="bbb.txt" />
>                 </fileset>
>         </includes>
>         <excludes fileset="r2" />
>         <excludes>
>                 <fileset basedir="dir.c">
>                         <includes file="ccc.txt" />
>                 </fileset>
>                 <includes fileset="r3" />
>         </excludes>
> </fileset>

Nice Jarek. First I tried something very simmilar (named it includesFileset)
but then realize need for something like:

     <fileset id="docassemblies"/>

     <foreach item="File" property="filename">
    <in>
     ...
    </in>
    <do>
     ....some <if ...>s
      <fileset id="docassemblies" basedir="${xmldocbuild.dir}">
       <includesFileset refid="docassemblies"/>
       <includes name="${filename}.dll"/>
      </fileset>
    </do>
   </fileset>
 ...
   <ndoc failonerror="true">
     <assemblies refid="docassemblies"/>
     ...
   </ndoc>
 ...

then after comments from Gert and Ian I came with more general approach to
merge general types (redefinemode).
But I share your doubt that xml merging will be enough...

btw: <xml> type if we introduce it later could be nice to be mergable. But
am not sure whether simple xml merge will be sufficient for it either.

> 4. This approach has the nice property of being side-effect-free - it can
be
> used in all places where a <fileset> is expected. I'm not sure how would
> <fileset ... redefinemode="Append"> behave in this case.

Hmm. True. You could always define new id and reference it but... Good
point!

I think it is doable. Let me think about it a little deeper.

Martin



-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers

Reply via email to