Thanks for the tip Ian. I've not installed and cvs stuff on my computer. Where do I find the diff command? Could you help me find some detailed information on how to create a patch format?
Regards, Jan -----Original Message----- From: Ian MacLean [mailto:[EMAIL PROTECTED] Sent: 27. november 2003 09:04 To: Jan Lønsetteig Cc: [EMAIL PROTECTED] Subject: Re: [NAntC-Dev] StarTeam bug - and fix thanks for the change Jan but could you please submit in patch format. Either run the diff command - diff -u or use the built in patch generator in tortoisecvs. I realize that this is a small change but in general patch sumissions are preferred. thanks Ian Jan Lønsetteig wrote: >Hi there, > >I've found a bug in the StarTeamCheckout, StarTeamCheckin and StarTeamList tasks. The >problem is that the code don't use the working folders specified in StarTeam. They >use the StarTeam folders to construct the file path and this result in wrong >placement of the files. > >Could someone with access be so kind as to verify and update the StarTeamCheckout.cs, >StarTeamCheckin.cs and StarTeamList.cs files with the following fixes? > >The >protected override void visit(InterOpStarTeam.StFolder starteamFolder, FileInfo >targetFolder) >method have to be updated for all three files. > >In the >foreach(InterOpStarTeam.StFolder stFolder in starteamFolder.SubFolders) >loop. > >Replace this line: >FileInfo targetSubfolder = new FileInfo(Path.Combine(targetFolder.FullName, >stFolder.Name)); >with this line: >FileInfo targetSubfolder = new FileInfo(stFolder.Path); > > >So this is a one-line change for each of the files. I've tested this with the >StarTeamCheckout task and it works fine. > > >Regards, >Jan Lønsetteig > > > >------------------------------------------------------- >This SF.net email is sponsored by: SF.net Giveback Program. >Does SourceForge.net help you be more productive? Does it >help you create better code? SHARE THE LOVE, and help us help >YOU! Click Here: http://sourceforge.net/donate/ >_______________________________________________ >NAntContrib-Developer mailing list >[EMAIL PROTECTED] >https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer > > -- Ian MacLean, Developer, ActiveState, a division of Sophos http://www.ActiveState.com ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ NAntContrib-Developer mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer
