The fix sounds like it would be ok to commit. At this momment I do not have a StarTeam server/environment that I can test it against. Thus I guess I am not much assistance.
Kevin --- Gert Driesen <[EMAIL PROTECTED]> wrote: > Jan, > > I'd love to commit this fix, but as I don't know much about starteam myself > I think we should first have this verified by the original author of these > tasks (Kevin Miller) ... > > Kevin, can you verify this ? > > Thanks, > > Gert > > ----- Original Message ----- > From: "Jan Lønsetteig" <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Thursday, November 27, 2003 8:46 AM > Subject: [NAntC-Dev] StarTeam bug - and fix > > > Hi there, > > I've found a bug in the StarTeamCheckout, StarTeamCheckin and StarTeamList > tasks. The problem is that the code don't use the working folders specified > in StarTeam. They use the StarTeam folders to construct the file path and > this result in wrong placement of the files. > > Could someone with access be so kind as to verify and update the > StarTeamCheckout.cs, StarTeamCheckin.cs and StarTeamList.cs files with the > following fixes? > > The > protected override void visit(InterOpStarTeam.StFolder starteamFolder, > FileInfo targetFolder) > method have to be updated for all three files. > > In the > foreach(InterOpStarTeam.StFolder stFolder in starteamFolder.SubFolders) > loop. > > Replace this line: > FileInfo targetSubfolder = new FileInfo(Path.Combine(targetFolder.FullName, > stFolder.Name)); > with this line: > FileInfo targetSubfolder = new FileInfo(stFolder.Path); > > > So this is a one-line change for each of the files. I've tested this with > the StarTeamCheckout task and it works fine. > > > Regards, > Jan Lønsetteig > > > > ------------------------------------------------------- > This SF.net email is sponsored by: SF.net Giveback Program. > Does SourceForge.net help you be more productive? Does it > help you create better code? SHARE THE LOVE, and help us help > YOU! Click Here: http://sourceforge.net/donate/ > _______________________________________________ > NAntContrib-Developer mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer > > ===== The cow is of bovine ilk. One end moo. The other milk. __________________________________ Do you Yahoo!? Free Pop-Up Blocker - Get it now http://companion.yahoo.com/ ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ NAntContrib-Developer mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer
