Hello Gert, > - Does "viewpath" always refer to a file/directory path ? If so, we should > have it backed by FileInfo instead of string. NAnt will automatically > resolve paths to absolute paths if the attribute is backed by FileInfo.
I think that would be fine. The only issue I can think of is if there is an alternative way to get to specify the path (ie like a ClearCase specific path description), but I'm not aware of any - I always use a regular path. Let's make viewpath's FileInfo's until told otherwise. :) > - Are there other attributes that always refer to a file/directory ? I > already modified CommentFile from string to FileInfo. I *think* we can also change "out" in cccheckout, "vob" in ccmklabel and ccmklabeltype and "log" in ccupdate. I say 'think' because I those commands are pretty obscure and I've never used them. And, unfortunately I don't have the ClearCase command reference here (I'm on temporary assignment in the US for another couple of months - the reference documentation is sittng on my desk!). But I think it's safe to assume that they're ok. > - We should probably quote more commandline arguments. Can you look into > this after I've committed your tasks to cvs ? Sure. I actually copied the examples from the Ant ClearCase tasks. But I should've added more. > - Can you add documentation for the TypeKind enum (which I've added) after > the changes are committed to cvs ? Yep - and thanks for making the change. I'd seen the enum used elsewhere (in one of the perforce tasks I think) and suspected that I was doing something wrong... > - Can you test the changes I made to ensure I did not introduce regression ? I'd be happy to eyeball them but I don't have ClearCase installed on my laptop so I can't actually do any testing... :( I may be able to send a copy of the build to one of the developers back home to test. I'll ask them nicely. ;) > I'll commit to cvs tomorrow, and will upload a new nightly build after that. Excellent. Thanks for all your reviewing and integrating work! Cheers, Matt ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642 _______________________________________________ NAntContrib-Developer mailing list NAntContrib-Developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer
