I didn't realize static methods use a different pattern. Looks good now.
Hannes
Am 2015-06-09 um 10:43 schrieb A. Sundararajan:
Fixed that sample: http://cr.openjdk.java.net/~sundar/8086032/webrev.01/
PS. slightly different pattern of string for static vs instance methods..
Thanks,
-Sundar
On Tuesday 09 June 2015 01:44 PM, Hannes Wallnoefer wrote:
The "methods" function in javahelp.js should use str.lastIndexOf(']')
to get the end of the string, otherwise an array return value or
parameter will trip it up.
I'm wondering why the terminating "undefined" is necessary. The
load() function should really always return undefined, it does so in
all other JavaScript shells. Even so, I'm not sure it is it correct
that load returns the last declared function? Going to consult the
spec about this.
Otherwise +1, nice addition to the tests!
Hannes
Am 2015-06-09 um 07:15 schrieb A. Sundararajan:
Please review http://cr.openjdk.java.net/~sundar/8086032/ for
https://bugs.openjdk.java.net/browse/JDK-8086032
Thanks,
-Sundar
