Hi Sundar,

thumbs are still up.

At some point, I think it would make sense to place the dynalink samples in a 
dedicated place and provide one dedicated JS file for the compilation and JAR 
generation that the various samples can just load() at the beginning. The 
proliferation of ever-similar sample_linker.js files might eventually be 
overwhelming.

Best,

Michael

> Am 08.12.2015 um 09:05 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Hi,
> 
> I've updated webrev to include another sample (treating nio Buffer objects 
> like arrays). Updated webrev is @ 
> http://cr.openjdk.java.net/~sundar/8144841/webrev.01/
> 
> Thanks,
> -Sundar
> 
> On 12/8/2015 1:31 PM, Michael Haupt wrote:
>> Hi Sundar,
>> 
>> lower-case thumbs up!
>> 
>> Best,
>> 
>> Michael
>> 
>>> Am 07.12.2015 um 16:46 schrieb Sundararajan Athijegannathan 
>>> <sundararajan.athijegannat...@oracle.com>:
>>> 
>>> Please review http://cr.openjdk.java.net/~sundar/8144841/ for 
>>> https://bugs.openjdk.java.net/browse/JDK-8144841
>>> 
>>> Adding a README for dynalink samples as Marcus suggested earlier.
>>> 
>>> Thanks,
>>> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>     Oracle is committed to developing 
practices and products that help protect the environment

Reply via email to