Well, marking text never worked due to the fact that there's no way to
determine what part is the text area and what is the button part (using SWT
API and non-native calls) - but instead of saying that will never work I did
some workaround and added code for that based on assumption of button sizes
for the different platforms (Windows, Carbon, GTK), and that seems to work
rather well. Those sizes can be changed by the settings in case I missed
some pixels. I can only test on XP currently.

Also fixed the other problem you mentioned. I now set the date (if parsable)
whenever the combo is opened, that way any entered text will be set right
away and the combo will open with the right date as well. So that should
truly fix any resetting of dates.

I have also been slowly working on adding a long forgotten feature and
decided to throw that in too in this update, which is that you can set a
date for when the combo should not allow clicks prior-to or after, that way
you can limit the range of allowed dates (disallowed dates are grayed out -
customizable color-wise of course). This is pretty standard in other
calendar selectors, and it was easy enough to add so I thought "why not".
Date-range selection is still on the todo list.

Oh, and the combo now supports SWT.RIGHT_TO_LEFT as well.

So, all in all, changed files are (if you are planning to merge code with
yours):
AbstractColorManager.java
AbstractSettings.java
CalendarCombo.java
CalendarComposite.java
IColorManager.java
ISettings.java
Tester.java

Let me know if you find any issues with all that, it seems to work well on
my end from what I can test. It's all in CVS.

Emil

On Wed, Apr 23, 2008 at 9:11 PM, B. Haje <[EMAIL PROTECTED]> wrote:

> [EMAIL PROTECTED] wrote:
> > Interesting bug. I repro'd and fixed. Looks like same bug and
> > the order of some code (like when it kills the previous popup before
> > opening it again).
> >
> > I also noticed that typing in a date in one combo doesn't
> > force a depending combo to use that typed-in date as it's
> > start date (as it doesn't fire a dateChange event when you
> > type in dates, for many reasons), so I fixed that too.
> >
> > Let me know how that works for you, and if you run into more.
> > I don't think the combo was very well tested in non-readonly
> > mode (it's been quite heavily tested in normal mode).
>
> Ok, doing some testing and debugging here. I'm still having problems:
>
> - I can't mark the text in the combofield anymore. It always opens the
> calendar-window.
>
> - when changing the date in the field it only gets valid after I have
> opened
> the calendar-window once and(!) only if I open the calendar-window by
> clicking in the combofield, clicking on the arrow doesn't do it.
>
> Greetings
>
> Bjoern
>
>
> _______________________________________________
> nebula-dev mailing list
> [email protected]
> https://dev.eclipse.org/mailman/listinfo/nebula-dev
>



-- 

Emil Crumhorn - [EMAIL PROTECTED]
Senior Software Engineer
http://www.hexapixel.com/
_______________________________________________
nebula-dev mailing list
[email protected]
https://dev.eclipse.org/mailman/listinfo/nebula-dev

Reply via email to