Ah, good point. I'll add that to the code tonight and commit as well, that's
a pretty obvious piece of code :)

Thanks,
Emil

On Thu, Apr 24, 2008 at 11:16 AM, B. Haje <[EMAIL PROTECTED]> wrote:

> [EMAIL PROTECTED] wrote:
> > Well, marking text never worked due to the fact that there's
> > no way to determine what part is the text area and what is
> > the button part (using SWT API and non-native calls) - but
> > instead of saying that will never work I did some workaround
> > and added code for that based on assumption of button sizes
> > for the different platforms (Windows, Carbon, GTK), and that
> > seems to work rather well. Those sizes can be changed by the
> > settings in case I missed some pixels. I can only test on XP
> > currently.
>
> Works fine for me, currently only on XP too.
>
> But it still does not set the date if the calendar window is never opened.
> I
> fixed that by changing the code of getDate():
>
>        public Calendar getDate() {
>                checkWidget();
>                if (!isReadOnly){
>                        setDateBasedOnComboText();
>                }
>                return mSetDate;
>        }
>
> Calling setDateBasedOnComboText does it for me.
>
> Greetings Bjoern
>
>
> >
> >
> > On Wed, Apr 23, 2008 at 9:11 PM, B. Haje <[EMAIL PROTECTED]> wrote:
> >
> >
> >       [EMAIL PROTECTED] wrote:
> >       > Interesting bug. I repro'd and fixed. Looks like same bug and
> >       > the order of some code (like when it kills the
> > previous popup before
> >       > opening it again).
> >       >
> >       > I also noticed that typing in a date in one combo doesn't
> >       > force a depending combo to use that typed-in date as it's
> >       > start date (as it doesn't fire a dateChange event when you
> >       > type in dates, for many reasons), so I fixed that too.        >
> >       > Let me know how that works for you, and if you run into more.
> >       > I don't think the combo was very well tested in non-readonly
> >       > mode (it's been quite heavily tested in normal mode).
> >
> >
> >       Ok, doing some testing and debugging here. I'm still
> > having problems:
> >
> >       - I can't mark the text in the combofield anymore. It
> > always opens the
> >       calendar-window.
> >
> >       - when changing the date in the field it only gets
> > valid after I have opened
> >       the calendar-window once and(!) only if I open the
> > calendar-window by
> >       clicking in the combofield, clicking on the arrow doesn't do it.
> >
> >
> >       Greetings
> >
> >       Bjoern
> >
> >
> >       _______________________________________________
> >       nebula-dev mailing list
> >       [email protected]
> >       https://dev.eclipse.org/mailman/listinfo/nebula-dev
>
>
>
> _______________________________________________
> nebula-dev mailing list
> [email protected]
> https://dev.eclipse.org/mailman/listinfo/nebula-dev
>



-- 

Emil Crumhorn - [EMAIL PROTECTED]
Senior Software Engineer
http://www.hexapixel.com/
_______________________________________________
nebula-dev mailing list
[email protected]
https://dev.eclipse.org/mailman/listinfo/nebula-dev

Reply via email to