Hi Mikhail, thanks for sending in the patches. On Wed, Oct 12, 2005 at 09:15:18PM -0400, Mikhail Teterin wrote: > Hello! > > I have the following three patchsets for Neon 0.25.3 > > 1) patch-auth -- fix use of GSSAPI. Streamline generation of 16 > random bytes -- this hunk is only portable, to where there is > srandomdev(), but OpenSSL is not required;
This mixes two separate changes so is hard to review. A patch to optionally add support for srandomdev() would be welcome. The GSSAPI changes look good, thanks, I've committed that. > 2) patch-md5 -- when already using OpenSSL (almost always), use > OpenSSL's MD5 implementation, instead of Neon's own. It is, probably, > more reliable and, sometimes, assembly- and/or hardware-optimized. This breaks the library ABI so absolutely cannot go in as-is. It could be redone to avoid that but I'm not particularly interested in introducing a new dependency on OpenSSL. neon's use of MD5 is so limited (and hardly speed critical) it's not really worth it. > 3) patch-tests -- several tests were failing. Please, take a look. > Some of these are, I'm sure, misguided... The patch also makes the > certificate-generation (for wildcard* tests) independant from Linux. > Instead of Linux-only features of hostname(1), it uses much wider > spread > features of modern sh (or bash or ksh) -- and now works on FreeBSD as > well. common/child.c: change looks spurious. why? test/request.c: that code triggered a real bug which was fixed recently test/socket.c: the ne_sock_connect_ssl() is only used if SOCKET_SSL is defined, when building socket-ssl -- what was the problem this "fixed"? test/lock.c: what was the problem? needs further diagnosis. The hostname munging could probably be rewritten using sed and be really portable. > Now, if only someone could update cadaver to work with the new neon... This is done in the repos trunk, I keep intending to make a release RSN :) Regards, joe _______________________________________________ neon mailing list [email protected] http://mailman.webdav.org/mailman/listinfo/neon
