On Thursday 13 October 2005 03:24 am, Joe Orton wrote:
= > I have the following three patchsets for Neon 0.25.3
= >
= > 1) patch-auth -- fix use of GSSAPI. Streamline generation of 16
= > random bytes -- this hunk is only portable, to where there is
= > srandomdev(), but OpenSSL is not required;
=
= This mixes two separate changes so is hard to review. A patch to
= optionally add support for srandomdev() would be welcome.
I don't know, how to change configure scripts. My point was not so much
about srandomdev, as that there is no need to MD5 random data to get
random data :-)
= The GSSAPI changes look good, thanks, I've committed that.
Thanks.
= > 2) patch-md5 -- when already using OpenSSL (almost always), use
= > OpenSSL's MD5 implementation, instead of Neon's own. It is, probably,
= > more reliable and, sometimes, assembly- and/or hardware-optimized.
=
= This breaks the library ABI so absolutely cannot go in as-is.
Sorry, if you really cared about compatibility, you would not have
broken the API compatibility, so that cadaver fails to build :)
As for ABI compatibility, the clients of the library should never
have used its md5 implementation anyway, should they have?
= It could be redone to avoid that but I'm not particularly interested
= in introducing a new dependency on OpenSSL. neon's use of MD5 is so
= limited (and hardly speed critical) it's not really worth it.
There is no new dependency on OpenSSL introduced by my patch. They
kick-in only if HAVE_OPENSSL is defined.
= > 3) patch-tests -- several tests were failing. Please, take a look.
= > Some of these are, I'm sure, misguided... The patch also makes the
= > certificate-generation (for wildcard* tests) independant from Linux.
= > Instead of Linux-only features of hostname(1), it uses much wider
spread
= > features of modern sh (or bash or ksh) -- and now works on FreeBSD as
= > well.
=
= common/child.c: change looks spurious. why?
I was hoping, it would make long_line_chunked run quicker. I don't
think, it helped though :-( Any better way to speed that test up?
= test/request.c: that code triggered a real bug which was fixed recently
Can we have a patch, please? Or is 0.25.4 going to be out in a few days?
= test/socket.c: the ne_sock_connect_ssl() is only used if SOCKET_SSL
= is defined, when building socket-ssl -- what was the problem this
= "fixed"?
I changed the begin() in the process of investigating the write_reset
failure in the non-SSL case. It expects reset, but was getting EPIPE
instead. I had to modify the write_reset() itself...
= test/lock.c: what was the problem? needs further diagnosis.
Don't know -- the server was closing connection instead of rejecting
authentication...
= The hostname munging could probably be rewritten using sed and be
= really portable.
Possibly. My patches are FreeBSD-centered :-) Please, take a look at
the `echo' commands too. To output octals one needs to use \0NNN -- the
unpatched version omits the leading zero, which causes the literal \NNN
to be used. This was breaking the subject-reading tests. I guess, echo
is broken on Linux (or in bash?) to allow octals without the leading
zero, but the bash man page there says, they are expected.
= > Now, if only someone could update cadaver to work with the new neon...
=
= This is done in the repos trunk, I keep intending to make a release
= RSN :)
This keeps us from upgrading the neon port... Please, make a release
soon. Thank you!
-mi
_______________________________________________
neon mailing list
[email protected]
http://mailman.webdav.org/mailman/listinfo/neon
