Brian, sorry for the slow reply, I've been away on holiday and got unsubscribed from the list due to bogus spam bounces in the mean time!
On Mon, Nov 14, 2005 at 10:35:34AM -0800, Brian Moran wrote: .. > For reference, here're links to the changes that we > submitted back in the summer: I'd really hoped that Vladimir would have the chance to review these changes as the author of the original code. But I'll do what I can: > 1) enabled NTLM auth to use credentials collected from > ne_set_server_auth > http://mailman.webdav.org/pipermail/neon/2005-July/002062.html This seems to be calling get_credentials() unconditionally which doesn't seem right. In normal use the whole point of this code is just to avoid that. > 2) Use the secur32.dll that exists on some Windows > systems for security operations This seems separate from the other changes, right? Plus this bit: - hSecDll = LoadLibrary("security.dll"); + hSecDll = LoadLibrary(_TEXT("security.dll")); can you send a separate patch for this bit, it seems obvious for me to apply. Please avoid making spurious whitespace changes in posted patches, BTW. Regards, joe _______________________________________________ neon mailing list [email protected] http://mailman.webdav.org/mailman/listinfo/neon
