> On June 7, 2012, 2:36 p.m., Sebastian Trueg wrote: > > The problem with this fix is that it breaks tree listings. That was the > > original reason for the code you comment out. So a real fix would look > > different. Sadly I do not have much time for Nepomuk these days... so I > > would accept the patch if it contained a big comment. > > Simeon Bird wrote: > Is there a user visible way to see a tree listing that would be broken? > If there is something I could test I could perhaps cook up the real fix. > > Thanks > > Sebastian Trueg wrote: > Sure, just open a search in the dolphin tree view. > > Simeon Bird wrote: > So while I was playing with this, I updated to 4.9 and it seems one can > no longer see the tree listings in dolphin search; it just comes out as a > flat directory, without the expander arrows. Presumably this was done to > match how filenamesearch:// works, but it means I can't find anything > actually broken by the patch any more. > > So shall we go with the "apply with big comment" approach? > > Thanks > > Sebastian Trueg wrote: > That would be fine I suppose. Maybe let vhanda comment on this also...
I'm fine with the big comment approach for now. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105158/#review14470 ----------------------------------------------------------- On June 6, 2012, 2:13 a.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105158/ > ----------------------------------------------------------- > > (Updated June 6, 2012, 2:13 a.m.) > > > Review request for Dolphin, Nepomuk, Peter Penz, and Sebastian Trueg. > > > Description > ------- > > This patch attempts to fix bug 293111. > > The problem is that the nepomuk kioslave gives files a targetUrl > understandable by non-KDE applications (ie, their real path on the > filesystem). > > However, it does not give this to directories, and it only does the fancy > stuff on the query folder, not any subfolders. The subfolders are opened with > the kioslave base listdir class. The easy way to fix this is to set > UDS_TARGET_URL for director a "real" url, which is what the attached patch > does. > > > This addresses bug 293111. > http://bugs.kde.org/show_bug.cgi?id=293111 > > > Diffs > ----- > > nepomuk/kioslaves/search/searchfolder.cpp 8088c46 > > Diff: http://git.reviewboard.kde.org/r/105158/diff/ > > > Testing > ------- > > I compiled and ran it on my machine with some search results. Not tested on > search results that are not local files. > > > Thanks, > > Simeon Bird > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
