> On July 17, 2012, 10:28 p.m., Simeon Bird wrote: > > Ship It! > > Simeon Bird wrote: > I updated the patch with a big comment. Thanks for reviewing! > > Can it get into some 4.9 point release, or does it wait until 4.10? > > Vishesh Handa wrote: > Please commit it in both master and 4.9
I don't think I have commit rights. - Simeon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105158/#review16045 ----------------------------------------------------------- On July 17, 2012, 10:28 p.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105158/ > ----------------------------------------------------------- > > (Updated July 17, 2012, 10:28 p.m.) > > > Review request for Dolphin, Nepomuk, Peter Penz, and Sebastian Trueg. > > > Description > ------- > > This patch attempts to fix bug 293111. > > The problem is that the nepomuk kioslave gives files a targetUrl > understandable by non-KDE applications (ie, their real path on the > filesystem). > > However, it does not give this to directories, and it only does the fancy > stuff on the query folder, not any subfolders. The subfolders are opened with > the kioslave base listdir class. The easy way to fix this is to set > UDS_TARGET_URL for director a "real" url, which is what the attached patch > does. > > > This addresses bug 293111. > http://bugs.kde.org/show_bug.cgi?id=293111 > > > Diffs > ----- > > nepomuk/kioslaves/search/searchfolder.cpp e8c8369 > > Diff: http://git.reviewboard.kde.org/r/105158/diff/ > > > Testing > ------- > > I compiled and ran it on my machine with some search results. Not tested on > search results that are not local files. > > > Thanks, > > Simeon Bird > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
