> On Jan. 3, 2013, 10:44 p.m., Vishesh Handa wrote:
> > I don't think this is a good idea. Well, not the way it has been done.
> > 
> > It would be better if this was transparently handled by the 
> > FileIndexerConfig, and it not be saved in the config file. If we do not 
> > save it in the config file then we don't need to have a special case for it 
> > in the KCM.
> > 
> > Also, considering that that this "data" directory is generally present in a 
> > hidden folder. I'm not sure if this will work. Did you test it?

I agree that this should be dealt internally and transparently.
Let me go over the code a bit more carefully so I can figure out how to do it.
I will submit a new review request when I do.


- Luis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108149/#review24623
-----------------------------------------------------------


On Jan. 3, 2013, 10:34 p.m., Luis Silva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108149/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2013, 10:34 p.m.)
> 
> 
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Add the $HOME/.kde/share/apps/nepomuk/data folder to be indexed by default. 
> Most of the kios I am writing depend on this, especially since the webminer 
> saves the data to this folder. 
> This is similar to what the tvnamer does.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/fileindexerconfig.cpp 
> 0e0e4aead7b422980d4c1713f52de4269c0e4f8e 
> 
> Diff: http://git.reviewboard.kde.org/r/108149/diff/
> 
> 
> Testing
> -------
> 
> I am not sure if this is the correct way to do it but since the webminer 
> saves all its data here by defailt, any consumers need to have the data 
> indexed (level 2).
> 
> 
> Thanks,
> 
> Luis Silva
> 
>

_______________________________________________
Nepomuk mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/nepomuk

Reply via email to