Alan,
On 29/05/2019 08:01, Alan Bateman wrote:
On 28/05/2019 15:39, Chris Hegarty wrote:
...
https://cr.openjdk.java.net/~chegar/8224730/webrev.00/
This looks good. I just wonder if there is any merit is extending the
test to exercise the socket adaptors returned by
SocketChannel::socketand ServerSocketChannel::socket or maybe checking a
separate test. The socket adaptors are often forgotten and I'm only
bringing it up here while the issue with toString is fresh.
Good idea. I've expanded the test to cover the ServerSocket adapter too.
Good news is that it found no issues ( but of course will increase
coverage and catch possible future accidental breakages ).
Webrev:
https://cr.openjdk.java.net/~chegar/8224730/webrev.01/
CSR - to cover the minor spec clarification:
https://bugs.openjdk.java.net/browse/JDK-8224972
-Chris.
