Alan,
On 29/05/2019 12:50, Alan Bateman wrote:
On 29/05/2019 12:36, Chris Hegarty wrote:
Good idea. I've expanded the test to cover the ServerSocket adapter too.
Good news is that it found no issues ( but of course will increase
coverage and catch possible future accidental breakages ).
Webrev:
https://cr.openjdk.java.net/~chegar/8224730/webrev.01/
One suggestion is to rename the socketAdapterXXX methods to
serverSocketAdaptorXXX to align with the class name. Otherwise looks good.
Yes, that is better.
Updated webrev:
https://cr.openjdk.java.net/~chegar/8224730/webrev.02/
CSR - to cover the minor spec clarification:
https://bugs.openjdk.java.net/browse/JDK-8224972
I've added myself as Reviewer to the CSR.
Thank you. Finalized.
-Chris.
