> On 16 Aug 2019, at 10:51, Baesken, Matthias <matthias.baes...@sap.com> wrote: > > Thanks alot ! > > I guess I can push this as trivial (but a second reviewer would be good too > ).
The change looks fine. You could probably drop the comment, I don’t think that it’s really needed. > Best regards, Matthias > >> -----Original Message----- >> From: Daniel Fuchs <daniel.fu...@oracle.com> >> ... >> >> I haven't observed any failures over 50 runs on all >> platforms tested. macosx is problem listed for this >> test so it wasn't run there - but all others platforms >> passed with your changes. The set of checks in the NetworkConfiguration for has_testableipv6address could probably be expanded to include macOS. The maybe the test could be removed from the ProblemList ( for mac ). But that is a separate issue, for a follow-on, verification, testing, etc. -Chris.
