Hi,
After some discussion offline, it was decided that a try-with-resources
was preferred to a @BeforeTest @AfterTest for creating and closing
sockets. I’ve updated the webrev to reflect this, and the new patch can
be found below.
http://cr.openjdk.java.net/~pconcannon/8243488/webrevs/webrev.02/
Kind regards,
Patrick
On 25/04/2020 15:53, Alan Bateman wrote:
On 24/04/2020 21:00, Patrick Concannon wrote:
Hi Alan,
Yeah, sounds good. I’ve added that test case as requested, and you
can find it in the updated webrev below.
http://cr.openjdk.java.net/~pconcannon/8243488/webrevs/webrev.01/
testInitialSendBufferSize looks good, thanks for adding that.
A minor nit is that the @AfterTest method is in the middle of several
tests so not easy to check that it cleans up exactly the resources
that the @BeforeTest method creates. It might be helpful to move it so
that it is declared after Setup. No new webrev needed for that of course.
-Alan
